filechooser: Disconnect signal handlers from search engine before destroying
authorCarlos Garnacho <carlosg@gnome.org>
Tue, 3 Mar 2015 12:34:03 +0000 (13:34 +0100)
committerCarlos Garnacho <carlosg@gnome.org>
Tue, 3 Mar 2015 16:57:08 +0000 (17:57 +0100)
The search engine might stay alive longer due to extra temporary refs, so
the signal handlers should be removed for the filechooser to ignore these
properly.

https://bugzilla.gnome.org/show_bug.cgi?id=745479

gtk/gtkfilechooserwidget.c

index 76512e0b8b173f96c9910263e5f55ee16d796655..8789f3f276bfc2dc8246b4c0d688d199fec2706f 100644 (file)
@@ -6205,7 +6205,7 @@ search_stop_searching (GtkFileChooserWidget *impl,
   if (priv->search_engine)
     {
       _gtk_search_engine_stop (priv->search_engine);
-      
+      g_signal_handlers_disconnect_by_data (priv->search_engine, impl);
       g_object_unref (priv->search_engine);
       priv->search_engine = NULL;
     }